Johnlon commented on a change in pull request #9456: FLINK-13588
flink-streaming-java don't throw away exception info in logging
URL: https://github.com/apache/flink/pull/9456#discussion_r314819650
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsynchronousException.java
##########
@@ -38,6 +38,10 @@ public AsynchronousException(String message, Throwable
cause) {
@Override
public String toString() {
- return "AsynchronousException{" + getCause() + "}";
+ if (getMessage() != null) {
+ return "AsynchronousException{" + getMessage() + ",
caused by " + getCause() + "}";
+ } else {
+ return "AsynchronousException{" + getCause() + "}";
+ }
Review comment:
Done.
This is a more intrusive change that may break more tests as it impacts the
route where the message was null.
Any objection to me changing the tests to assert on the default
AsyncException.toString() rendering?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
