wuchong commented on a change in pull request #9459:
[FLINK-13742][table-planner-blink] Fix code generation when aggregation
contains both distinct aggregate with and without filter.
URL: https://github.com/apache/flink/pull/9459#discussion_r314977208
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala
##########
@@ -1168,6 +1168,46 @@ class AggregateITCase(
assertEquals(expected.sorted, sink.getRetractResults.sorted)
}
+ @Test
+ def testDistinctWithMultiFilter(): Unit = {
+ val data = new mutable.MutableList[(Int, Long, String)]
+ data.+=((1, 1L, "Hi"))
+ data.+=((2, 2L, "Hello"))
+ data.+=((3, 2L, "Hello world"))
+ data.+=((4, 3L, "Hello world, how are you?"))
+ data.+=((5, 3L, "I am fine."))
+ data.+=((6, 3L, "Luke Skywalker"))
+ data.+=((7, 4L, "Comment#1"))
+ data.+=((8, 4L, "Comment#2"))
+ data.+=((9, 4L, "Comment#3"))
+ data.+=((10, 4L, "Comment#4"))
+
+ val sqlQuery =
+ s"""
+ |SELECT
+ | b,
+ | SUM(DISTINCT (a * 3)),
+ | COUNT(DISTINCT SUBSTRING(c FROM 1 FOR 2)),
+ | COUNT(DISTINCT c),
+ | COUNT(DISTINCT c) filter (where MOD(a, 3) = 0),
+ | COUNT(DISTINCT c) filter (where MOD(a, 3) = 1)
+ |FROM MyTable
+ |GROUP BY b"
Review comment:
There's an extra double quote.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
