wzhero1 commented on a change in pull request #9336:
[FLINK-13548][Deployment/YARN]Support priority of the Flink YARN application
URL: https://github.com/apache/flink/pull/9336#discussion_r314991911
##########
File path: docs/_includes/generated/yarn_config_configuration.html
##########
@@ -22,6 +22,11 @@
<td style="word-wrap: break-word;">"0"</td>
<td>With this configuration option, users can specify a port, a
range of ports or a list of ports for the Application Master (and JobManager)
RPC port. By default we recommend using the default value (0) to let the
operating system choose an appropriate port. In particular when multiple AMs
are running on the same physical host, fixed port assignments prevent the AM
from starting. For example when running Flink on YARN on an environment with a
restrictive firewall, this option allows specifying a range of allowed
ports.</td>
</tr>
+ <tr>
Review comment:
@walterddr I also found in 2.8.x, the `ApplicationReport` which is
generated by `yarnClient.getApplicationReport` has the method
`set/getPriority`, but there is no such method in 2.6.x.
> Hi here,
>
> did a bit of research: the API is already there in:
[ApplicationSubmissionContext](https://hadoop.apache.org/docs/r2.4.1/api/org/apache/hadoop/yarn/api/records/ApplicationSubmissionContext.html).
However, the usage pattern is different: it is only introduced to Capacity
scheduler in
[2.8.x](https://hadoop.apache.org/docs/r2.8.5/hadoop-yarn/hadoop-yarn-site/CapacityScheduler.html#Setup_for_application_priority).
>
> The priority setting was used in
[ResourceRequest](http://hadoop.apache.org/docs/r2.4.1/hadoop-yarn/hadoop-yarn-site/WritingYarnApplications.html),
which is a different usage pattern: after
[2.6.x](https://hadoop.apache.org/docs/r2.6.5//hadoop-yarn/hadoop-yarn-site/WritingYarnApplications.html),
YARN documentation indicates that `appContext.setPriority(...)` should be used
instead of `rsrcRequest.setPriority(...)`
>
> I am still not sure how prior to 2.6.x what is the effect of setting
`appContext.setPriority`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
