twalthr commented on a change in pull request #9423: [FLINK-13699][table-api]
Fix TableFactory doesn't work with DDL when containing TIMESTAMP/DATE/TIME types
URL: https://github.com/apache/flink/pull/9423#discussion_r315202255
##########
File path:
flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseConnectorITCase.java
##########
@@ -320,6 +336,72 @@ public void testTableSink() throws Exception {
TestBaseUtils.compareResultAsText(results, expected);
}
+ @Test
+ public void testTableSourceSinkWithDDL() throws Exception {
+ StreamExecutionEnvironment execEnv =
StreamExecutionEnvironment.getExecutionEnvironment();
+ StreamTableEnvironment tEnv =
StreamTableEnvironment.create(execEnv, streamSettings);
+
+ DataStream<Row> ds =
execEnv.fromCollection(testData1).returns(testTypeInfo1);
+ tEnv.registerDataStream("src", ds);
+
+ // register hbase table
+ String quorum = getZookeeperQuorum();
+ String ddl = "CREATE TABLE hbase (\n" +
+ " rowkey INT," +
+ " family1 ROW<col1 INT>,\n" +
+ " family2 ROW<col1 VARCHAR, col2 BIGINT>,\n" +
Review comment:
Use `STRING` instead of `VARCHAR` and `TIMESTAMP(3)`/`TIME(3)` instead of
`TIMESTAMP`/`TIME`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
