zhijiangW commented on a change in pull request #9471: [FLINK-13754][task]
Decouple OperatorChain from StreamStatusMaintainer
URL: https://github.com/apache/flink/pull/9471#discussion_r315257456
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1293,10 +1292,10 @@ private void
checkpointStreamOperator(StreamOperator<?> op) throws Exception {
StreamEdge edge,
int outputIndex,
Environment environment,
- String taskName,
Review comment:
There are two options:
- Not pass the heavy-height `Environment` here and pass the individual
required fields from it.
- Pass the big component `Environment` instead of every tiny fields.
I prefer the first option but it might bring more refactoring works, so I
take the second way here. The task name could be got directly from
`Environment`, no need to explicitly pass it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
