becketqin commented on a change in pull request #9387: [FLINK-13231] [pubsub]
Replace Max outstanding acknowledgement ids li…
URL: https://github.com/apache/flink/pull/9387#discussion_r315260401
##########
File path:
flink-connectors/flink-connector-gcp-pubsub/src/main/java/org/apache/flink/streaming/connectors/gcp/pubsub/PubSubSource.java
##########
@@ -264,12 +263,11 @@ private
PubSubSourceBuilder(PubSubDeserializationSchema<OUT> deserializationSche
}
/**
- * Set a limit of the number of outstanding or to-be
acknowledged messages.
- * default is 10000. Adjust this if you have high checkpoint
intervals and / or run into memory issues
- * due to the amount of acknowledgement ids. Use {@link
PubSubSource}.NO_MAX_MESSAGES_TO_ACKNOWLEDGE_LIMIT if you want to remove the
limit.
+ * Set a limit on the rate of messages per second received.
This limit is per parallel instance of the source function.
+ * Default is set to 100000 messages per second.
*/
- public PubSubSourceBuilder<OUT> withMaxMessageToAcknowledge(int
maxMessageToAcknowledge) {
- this.maxMessageToAcknowledge = maxMessageToAcknowledge;
+ public PubSubSourceBuilder<OUT> withRateLimit(int
messagePerSecondRateLimit) {
Review comment:
I renamed this method to `withMessageRateLimit` in case we will have bytes
rate limit in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
