sjwiesman commented on issue #9444: [FLINK-13726][docs] build docs with jekyll 
4.0.0.pre.beta1
URL: https://github.com/apache/flink/pull/9444#issuecomment-522640745
 
 
   Ran locally and this is definitely an improvement. One question,  the notes 
for Jekyll 4.0 states that there is a breaking change for `{% link %}` that 
looks like it should break all the links in our docs but it doesn't. I ran 
`./check-links.sh` and clicked through a little bit and everything seems to 
work. Am I missing something? 
   
   ```
     * Our `link` tag now comes with the `relative_url` filter incorporated 
into it.
       You should no longer prepend `{{ site.baseurl }}` to `{% link foo.md %}`
       For further details: https://github.com/jekyll/jekyll/pull/6727
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to