1u0 commented on a change in pull request #9470: [FLINK-13380][k8s] Improve the 
usability of Flink session cluster on Kubernetes
URL: https://github.com/apache/flink/pull/9470#discussion_r315346551
 
 

 ##########
 File path: docs/ops/deployment/kubernetes.md
 ##########
 @@ -166,18 +242,31 @@ kind: Service
 metadata:
   name: flink-jobmanager
 spec:
+  type: ClusterIP
   ports:
   - name: rpc
     port: 6123
   - name: blob
     port: 6124
-  - name: query
-    port: 6125
   - name: ui
     port: 8081
   selector:
     app: flink
     component: jobmanager
+---
+apiVersion: v1
+kind: Service
+metadata:
+  name: flink-jobmanager-svc
+spec:
+  type: NodePort
 
 Review comment:
   If your situation is in some test/development setup, you can try to:
    * run `kubectl port-forward ${flink-jobmanager-pod} 8081:8081` to make JM 
reachable from your local machine (where you run `bin/flink run -m ...`).
    * I don't know well the `bin/flink run -m ${endpoint}` functionality, but 
if it doesn't work with urls that have additional path, the script/program 
behind it could have been extended to support such endpoints (smt. like: 
`bin/flink -m 
"http://localhost:8081/api/v1/namespaces/default/services/flink-jobmanager:ui/proxy";
 ...`).
   
   If the Kubernetes resources and the documentation here are served as some 
recommended/exemplar Flink cluster setup, then adding a service definition that 
exposes node port would be a bad example, imo.
   I suggest to remove the new service definition and maybe just add some more 
options (in the documentation) how developers can make JM reachable outside of 
test K8s cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to