NicoK commented on a change in pull request #9210: [FLINK-12746][docs] Getting
Started - DataStream Example Walkthrough
URL: https://github.com/apache/flink/pull/9210#discussion_r316212564
##########
File path: flink-end-to-end-tests/test-scripts/test_cli.sh
##########
@@ -29,23 +29,12 @@ $FLINK_DIR/bin/taskmanager.sh start
$FLINK_DIR/bin/taskmanager.sh start
# CLI regular expressions
-JOB_ID_REGEX_EXTRACTOR=".*JobID ([0-9,a-f]*)"
JOB_INFO_PACT_DATA_SOURCE_REGEX_EXTRACTOR="\"pact\": \"(Data Source)\""
JOB_INFO_PACT_DATA_SINK_REGEX_EXTRACTOR="\"pact\": \"(Data Sink)\""
JOB_LIST_REGEX_EXTRACTOR_BY_STATUS="([0-9,a-f]*) :"
EXIT_CODE=0
-function extract_job_id_from_job_submission_return() {
- if [[ $1 =~ $JOB_ID_REGEX_EXTRACTOR ]];
- then
- JOB_ID="${BASH_REMATCH[1]}";
- else
- JOB_ID=""
- fi
- echo "$JOB_ID"
-}
-
Review comment:
I think, you missed putting this function into `common.sh` because now, it
is not defined anywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
