[ 
https://issues.apache.org/jira/browse/FLINK-13573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16912403#comment-16912403
 ] 

TisonKun commented on FLINK-13573:
----------------------------------

[~till.rohrmann] I think this issue could be addressed on the fly with 
FLINK-10333 when we rework dispatcher and job recovery, while it is also able 
to be a individually addressed issue.

There is no effective problems on compatibility and we could get rid of a 
redundant wrapper for clear concepts serving. And I think this is enough for a 
so-called valid problem.

Here I'd like to share some thoughts with the community. In my opinion a robust 
project is open to minor refactors/changes. If such minor effort hard to be 
accepted with confidence, maybe we run into a situation where our code itself 
out of robustness. Give FLINK-13796 for an instance(and thus cc [~Fokko]), an 
unused private variable is always safely to be removed if it itself is out of 
use logically. We can pause or pending these issues because of the bandwidth of 
community resource but the attitude of community would be better to be open to 
these changes. We keep user-facing interfaces and functionalities stable and 
compatible while internal changes and evolutions are active. If our community 
has different idea, please let me know :P

> Merge SubmittedJobGraph into JobGraph
> -------------------------------------
>
>                 Key: FLINK-13573
>                 URL: https://issues.apache.org/jira/browse/FLINK-13573
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: TisonKun
>            Priority: Major
>             Fix For: 1.10.0
>
>
> As time goes on, {{SubmittedJobGraph}} becomes a thin wrapper of {{JobGraph}} 
> without any additional information. It is reasonable that we merge 
> {{SubmittedJobGraph}} into {{JobGraph}} and use only {{JobGraph}}. 
> WDYT? cc [~till.rohrmann] [~GJL]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to