bowenli86 commented on a change in pull request #8706:
[FLINK-12814][sql-client] Support a traditional and scrolling view of…
URL: https://github.com/apache/flink/pull/8706#discussion_r316411514
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/ExecutionEntry.java
##########
@@ -152,6 +156,8 @@ protected void validate(DescriptorProperties properties) {
properties.validateInt(EXECUTION_RESTART_STRATEGY_MAX_FAILURES_PER_INTERVAL,
true, 1);
properties.validateString(EXECUTION_CURRENT_CATALOG, true, 1);
properties.validateString(EXECUTION_CURRENT_DATABASE, true, 1);
+ properties.validateBoolean(EXECUTION_INTERACTIVE_VIEW_ENABLED,
true);
+ properties.validateInt(EXECUTION_MAX_QUERY_TIMEOUT_MS, true,
-1);
Review comment:
nit: feels like we can set a default timeout when
EXECUTION_INTERACTIVE_VIEW_ENABLED is false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
