bowenli86 commented on a change in pull request #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#discussion_r316421731
########## File path: flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE ########## @@ -12,15 +12,11 @@ This project bundles the following dependencies under the Apache Software Licens - com.amazonaws:jmespath-java:1.11.319 - org.apache.httpcomponents:httpclient:4.5.3 - org.apache.httpcomponents:httpcore:4.4.6 +- com.amazonaws:amazon-kinesis-client:1.10.0 Review comment: my "mvn dependency:tree" shows ``` [INFO] +- com.amazonaws:amazon-kinesis-client:jar:1.11.2:compile [INFO] | +- com.amazonaws:aws-java-sdk-dynamodb:jar:1.11.603:compile [INFO] | | \- com.amazonaws:aws-java-sdk-s3:jar:1.11.603:compile [INFO] | | \- com.amazonaws:aws-java-sdk-kms:jar:1.11.603:compile [INFO] | \- commons-logging:commons-logging:jar:1.1.3:compile ``` thus, are we missing `aws-java-sdk-dynamodb`, `aws-java-sdk-s3`, and `aws-java-sdk-kms`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
