zhijiangW commented on a change in pull request #9471: [FLINK-13754][task]
Decouple OperatorChain with StreamStatusMaintainer
URL: https://github.com/apache/flink/pull/9471#discussion_r316541630
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSourceContexts.java
##########
@@ -383,8 +383,6 @@ public WatermarkContext(
@Override
public void collect(T element) {
synchronized (checkpointLock) {
-
streamStatusMaintainer.toggleStreamStatus(StreamStatus.ACTIVE);
Review comment:
My previous thought was that the active status would be toggled in a
separate logic in other places before collecting. After thinking through it
again, it seems that this is only triggered via collecting elements or emitting
watermarks.
So you are right that we should not remove this action and keep it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
