mxm commented on a change in pull request #9497: [FLINK-13794][client] Remove
unused logic of printStatusDuringExecution
URL: https://github.com/apache/flink/pull/9497#discussion_r316555547
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
##########
@@ -163,23 +160,6 @@ public void shutdown() throws Exception {
// Configuration
//
------------------------------------------------------------------------
- /**
- * Configures whether the client should print progress updates during
the execution to {@code System.out}.
- * All updates are logged via the SLF4J loggers regardless of this
setting.
- *
- * @param print True to print updates to standard out during execution,
false to not print them.
- */
- public void setPrintStatusDuringExecution(boolean print) {
- this.printStatusDuringExecution = print;
- }
-
- /**
- * @return whether the client will print progress updates during the
execution to {@code System.out}
- */
- public boolean getPrintStatusDuringExecution() {
- return this.printStatusDuringExecution;
- }
Review comment:
Could we deprecate this method and just log a deprecation warning? We could
even remove the printing logic, so this would just be a placeholder not to
break the @Public contract.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
