TisonKun commented on a change in pull request #9512:
[FLINK-13819][coordination] Introduce State for RpcEndpoint
URL: https://github.com/apache/flink/pull/9512#discussion_r316742911
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcEndpoint.java
##########
@@ -323,6 +355,15 @@ public void validateRunsInMainThread() {
assert
MainThreadValidatorUtil.isRunningInExpectedThread(currentMainThread.get());
}
+ /**
+ * Rpc endpoint's state.
+ */
+ public enum State {
Review comment:
Thanks for your reply.
From JIRA it says "we suggest to introduce its state:..." without why the
exactly states.
It would be helpful if you write down the transitions. As @zentol's comment,
you can find `STOPPING` is not yet well-defined.
Let's say we prefer reaching a consensus in JIRA first on which states we
will introduce, accurate meaning of state, and when transition happens. Here is
one way to implement it and maybe it'd better to discuss the requirement on
JIRA first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
