[
https://issues.apache.org/jira/browse/FLINK-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942546#comment-14942546
]
ASF GitHub Bot commented on FLINK-2741:
---------------------------------------
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1221#issuecomment-145315514
Unfortunately looks like this patch does not take advantage of slf4j
parameterized logging [1].
Either do like:
log.info("=================================" + "\nTest " + description + "
is running." +
"\n--------------------------------------------------------------------------------");
or:
log.info("===============================" + "\nTest {} is running." +
"\n--------------------------------------------------------------------------------",
description);
[1] http://www.slf4j.org/faq.html#logging_performance
> Use single log statement in TestLogger
> --------------------------------------
>
> Key: FLINK-2741
> URL: https://issues.apache.org/jira/browse/FLINK-2741
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: master
> Reporter: Ufuk Celebi
> Assignee: rerngvit yanggratoke
> Priority: Trivial
>
> {{TestLogger}} prints log statements before and after tests. Currently this
> is done via multiple {{log.info}} statements. Sometimes this leads to
> interleaved output with failure stack traces.
> I would like to change it to a single statements with new lines:
> {code}
> 17:30:31,887 ERROR A - ---------------------------------------------
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,895 ERROR A - Test testJobManagerCleanUp(A) failed with:
> ...
> 17:30:31,909 ERROR A - =============================================
> {code}
> to
> {code}
> 17:30:31,891 INFO B - Shutting down remote daemon.
> 17:30:31,887 ERROR A -
> ---------------------------------------------------------------------
> Test testJobManagerCleanUp(A) failed with:
> ...
> =====================================================================
> {code}
> Any opinions? Does this improve readability?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
