kaibozhou edited a comment on issue #9517: [FLINK-13779][metrics] 
PrometheusPushGatewayReporter support push metrics with groupingKey
URL: https://github.com/apache/flink/pull/9517#issuecomment-524689138
 
 
   Hi, @StephanEwen @zentol  
   Thanks for your review. And if users do not specify groupingKey, the 
reporter will pass null which will be ignored by pushGateway. So it has no 
impact on the way of using the push gateway without grouping keys.
   
   The groupingKey is not just a global tag that applied to all metrics, but is 
also to specify the groups.   From the doc of 
[pushgateway](https://github.com/prometheus/pushgateway#command-line): 
   
   > "Pushed metrics are managed in groups, identified by a grouping key of any 
number of labels, of which the first must be the job label. The groups are easy 
to inspect via the web interface." 
   
   It is a special kind of label for pushgateway. The following two pictures 
are the tests I made.
   
   
![pic1](https://user-images.githubusercontent.com/1178321/63663939-226e1500-c7f7-11e9-86cf-f6403ee6d99d.png)
   
![pic2](https://user-images.githubusercontent.com/1178321/63663941-25690580-c7f7-11e9-8c23-c844958478fc.png)
   
   Thanks
   Kaibo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to