1u0 commented on a change in pull request #9383: [FLINK-13248] [runtime] Adding
processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r317617074
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
##########
@@ -1194,6 +1197,37 @@ public ExecutionConfig getExecutionConfig() {
return returnStream;
}
+ /**
+ * Method for passing user defined operators along with the type
information that will transform the DataStream.
+ *
+ * @param operatorName name of the operator, for logging purposes
+ * @param outTypeInfo the output type of the operator
+ * @param operatorFactory the factory for the operator.
+ * @param <R> type of the return stream
+ * @return the data stream constructed
+ */
+ @PublicEvolving
+ public <R> SingleOutputStreamOperator<R> transform(String operatorName,
TypeInformation<R> outTypeInfo,
+ OneInputStreamOperatorFactory<T, R> operatorFactory) {
Review comment:
Continuing my comment about deprecating the previous method:
imo, providing this method as the new alternative maybe not so user friendly
as users would need create additional layer (factory) to provide their own
operators.
Also, it may be not so easy to provide api stability from runtime point of
view, as the operator factories were mostly internal so far.
Maybe mark this method as `@Internal` at least for now? **Note** that
`StreamOperatorFactory` (parent of `OneInputStreamOperatorFactory`) is also
marked as `@Internal`.
**Nit:** the documentation string of this method is not exact, as the users
don't pass an operator instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
