[
https://issues.apache.org/jira/browse/FLINK-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916071#comment-16916071
]
Kostas Kloudas commented on FLINK-13850:
----------------------------------------
In general I agree with the idea of making the Config a "first class citizen",
I am not sure if the name is correct in all cases. Actually the whole
StreamingFileSink was created in a way so that it offers the minimal
functionality (but supports it well) and with the intention to add features as
users ask for it.
For example, I was thinking that for bulk formats, the compression algorithm or
format specific stuff will go in the there (or to a subclass of the config,
e.g. BulkFormatConfig). But then, the name partfileconfig may no longer be the
right name. This is my concern for "future-proof-ness"
> Refactor part file configuration into a single method
> -----------------------------------------------------
>
> Key: FLINK-13850
> URL: https://issues.apache.org/jira/browse/FLINK-13850
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / FileSystem
> Reporter: Gyula Fora
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there is only two methods on both format builders
> withPartFilePrefix and withPartFileSuffix for configuring the part files but
> in the future it is likely to grow.
> * More settings, different directories for pending / inprogress files etc
> I suggest we remove these two methods and replace them with a single :
> withPartFileConfig(..) where we use an extensible config class.
> This should be fixed before 1.10 in order to not release the other methods.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
