kl0u commented on issue #9176: [hotfix][client] Fix PreviewPlanEnvironment 
missing set up field "plan"
URL: https://github.com/apache/flink/pull/9176#issuecomment-525209100
 
 
   Hi @TisonKun, the `plan` field is only used in tests through `getPlan()` 
method and this commit does not seem to fix any problem. In addition, as you 
also pointed out, this whole class can be removed.
   
   Given the above, I do not see any reason for merging this as this is not a 
"fix".
   
   If I am missing something please let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to