twalthr commented on a change in pull request #9484: [FLINK-13774][table]
Expression DSL use should resolve Expressions in blink
URL: https://github.com/apache/flink/pull/9484#discussion_r318050540
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/ResolvedAggInputReference.java
##########
@@ -21,18 +21,22 @@
import org.apache.flink.table.expressions.Expression;
import org.apache.flink.table.expressions.ExpressionVisitor;
import org.apache.flink.table.expressions.FieldReferenceExpression;
+import org.apache.flink.table.expressions.ResolvedExpression;
+import org.apache.flink.table.types.DataType;
import org.apache.flink.table.types.logical.LogicalType;
import org.apache.flink.util.Preconditions;
import java.util.Collections;
import java.util.List;
+import static
org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter.fromLogicalTypeToDataType;
+
/**
* Normally we should use {@link FieldReferenceExpression} to represent an
input field.
* {@link FieldReferenceExpression} uses name to locate the field, in
aggregate case, we want to use
* field index.
*/
-public class ResolvedAggInputReference implements Expression {
+public class ResolvedAggInputReference implements ResolvedExpression {
Review comment:
Why do we still need this expression? `FieldReferenceExpression` has all we
need, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
