zhijiangW edited a comment on issue #9478: [FLINK-13766][task] Refactor the implementation of StreamInputProcessor based on StreamTaskInput#emitNext URL: https://github.com/apache/flink/pull/9478#issuecomment-525565847 Thanks for the review @pnowojski ! I have submitted the fixup commit for addressing above comments. For the performance concern of `emitRecord` in two input processor, I took the consumer way temporarily. If you prefer the abstract class way, then I could refactor this part later. In addition I think the existing constructor of processor seems too long, so I prefer to refactor the constructor a bit if you also agree. I agree with your suggestion that before merging we firstly focus on a `SourceReader` example based on this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
