tillrohrmann commented on a change in pull request #8175: [FLINK-9787]Change
ExecutionConfig#getGlobalJobParameters to return a…
URL: https://github.com/apache/flink/pull/8175#discussion_r318492834
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/ExecutionConfigTest.java
##########
@@ -159,4 +160,21 @@ public void testExecutionConfigSerialization() throws
IOException, ClassNotFound
assertEquals(sysoutLoggingEnabled,
copy1.isSysoutLoggingEnabled());
assertEquals(parallelism, copy1.getParallelism());
}
+
+ @Test
+ public void testGlobalParameters() {
Review comment:
I think it would be enough to test that when we call
`ExecutionConfig#getGlobalJobParameters()` without setting the value before,
returns a non null value. In general, we should not test multiple things in the
same test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
