twalthr commented on a change in pull request #8706: [FLINK-12814][sql-client] 
Support a traditional and scrolling view of…
URL: https://github.com/apache/flink/pull/8706#discussion_r318497498
 
 

 ##########
 File path: 
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/config/entries/ExecutionEntry.java
 ##########
 @@ -108,6 +108,10 @@
 
        public static final String EXECUTION_CURRENT_DATABASE = 
"current-database";
 
+       private static final String EXECUTION_INTERACTIVE_VIEW_ENABLED = 
"interactive-view.enabled";
 
 Review comment:
   I think I asked that in the past but why do we need an additional property? 
We have a property `result-mode` which could be extended by another enum value. 
Every additional config param should be well thought through because it 
increases the complexity for the user.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to