JingsongLi commented on a change in pull request #9485:
[FLINK-13775][table-planner-blink] Refactor
ExpressionConverter(RexNodeConverter) in blink
URL: https://github.com/apache/flink/pull/9485#discussion_r318549700
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/RexNodeConverter.java
##########
@@ -865,6 +865,9 @@ private static Calendar valueAsCalendar(Object value) {
@Override
public RexNode visit(FieldReferenceExpression fieldReference) {
+ // We can not use inputCount+inputIndex+FieldIndex to construct
field of calcite.
Review comment:
@dawidwys @twalthr What do you think about this question? Should it be a bug
of `QueryOperationConverter`? But I don't find any feasible in `RelBuilder`.
Maybe we should keep same order in `AggregateQueryOperation` or adjust the
order of existed `OperationTree`? Both ways look hard...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
