twalthr commented on a change in pull request #9354: [FLINK-13568][sql-parser]
DDL create table doesn't allow STRING data …
URL: https://github.com/apache/flink/pull/9354#discussion_r318545220
##########
File path:
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlCreateTable.java
##########
@@ -136,10 +136,12 @@ public void validate() throws SqlParseException {
SqlTableColumn tableColumn =
(SqlTableColumn) column;
columnName =
tableColumn.getName().getSimple();
String typeName =
tableColumn.getType().getTypeName().getSimple();
- if
(SqlColumnType.getType(typeName).isUnsupported()) {
+ if (typeName == null) {
throw new SqlParseException(
column.getParserPosition(),
- "Not support type [" +
typeName + "], at " + column.getParserPosition());
+ "Non supported type for
column ["
Review comment:
nit: `Unsupported type for column`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
