dyanarose commented on a change in pull request #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#discussion_r318592296
########## File path: NOTICE-binary ########## @@ -54,7 +54,6 @@ Copyright 2006-2019 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). - Review comment: just pegging this in here, to make sure we're all on the same page: https://github.com/apache/flink/pull/9494#discussion_r316597961 Since the kinesis connector will be building and released with Flink once this PR is merged in, we should be adding the dependencies to the NOTICE-binary file, correct? @zentol ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
