dyanarose commented on issue #9494: [FLINK-12847] [Connectors / Kinesis] update flink-connector-kinesis to use Apache 2.0 licensed code URL: https://github.com/apache/flink/pull/9494#issuecomment-525761325 > Please also update documentations upon removing "include-kinesis" > > ``` > $ ag include-kinesis > dev/connectors/kinesis.zh.md > 49:mvn clean install -Pinclude-kinesis -DskipTests > 52:mvn clean install -Pinclude-kinesis -DskipTests > 62:mvn clean install -Pinclude-kinesis -Daws.kinesis-kpl.version=0.12.6 -DskipTests > > dev/connectors/kinesis.md > 48:mvn clean install -Pinclude-kinesis -DskipTests > 51:mvn clean install -Pinclude-kinesis -DskipTests > 61:mvn clean install -Pinclude-kinesis -Daws.kinesis-kpl.version=0.12.6 -DskipTests > ``` these are referring to how to build for prior versions. 🤔 should this entire section be removed do you think. Leave in the mention of the licensing issue in prior versions, and then say something like "refer to the kinesis connector documentation for the version you are running" ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
