zentol commented on a change in pull request #9552: [FLINK-13884] Set default
failure rate restart strategy delay to 0s
URL: https://github.com/apache/flink/pull/9552#discussion_r318640674
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
##########
@@ -93,7 +93,12 @@
* It can be specified using Scala's FiniteDuration notation: "1 min",
"20 s".
*/
@PublicEvolving
- public static final String RESTART_STRATEGY_FAILURE_RATE_DELAY =
"restart-strategy.failure-rate.delay";
Review comment:
For converting constants to options so far we followed a different approach:
add new ConfigOptions into the appropriate `*Options` class, deprecate the
existing constant in `ConfigConstants` and link to the new option.
Ultimately, the goal is for ConfigConstants to be fully deprecated _at some
point_.
This may be a good opportunity to move all restart-related options into a
dedicated or existing *Options class. This would have the added benefit that
they'd be covered by the docs generator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
