xuefuz commented on a change in pull request #9547: [FLINK-13877][hive] Support Hive version 2.1.0 and 2.1.1 URL: https://github.com/apache/flink/pull/9547#discussion_r318740225
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV210.java ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.catalog.hive.client; + +import org.apache.flink.table.catalog.exceptions.CatalogException; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.apache.hadoop.hive.metastore.HiveMetaStoreClient; +import org.apache.hadoop.hive.metastore.IMetaStoreClient; +import org.apache.hadoop.hive.metastore.RetryingMetaStoreClient; +import org.apache.hadoop.hive.metastore.api.EnvironmentContext; +import org.apache.hadoop.hive.metastore.api.InvalidOperationException; +import org.apache.hadoop.hive.metastore.api.MetaException; +import org.apache.hadoop.hive.metastore.api.Partition; +import org.apache.thrift.TException; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; + +/** + * Shim for Hive version 2.1.0. + */ +public class HiveShimV210 extends HiveShimV122 { + + @Override + public IMetaStoreClient getHiveMetastoreClient(HiveConf hiveConf) { + try { + Class<?>[] constructorArgTypes = {HiveConf.class}; + Object[] constructorArgs = {hiveConf}; + Method method = RetryingMetaStoreClient.class.getMethod("getProxy", HiveConf.class, Review comment: Actually the implementation in HiveShimV230 is the first thing I tried. It didn't work. The reason is that getProxy(HiveConf hiveConf, boolean allowEmbedded) actually calls the same getProxy() as what I did above, but with additional argument HiveMetaHookLoader.class. However, we don't have an instance of HiveMetaHookLoader.class, and a "null" value doens't work when when invoking the method. You can try and probably get a better idea of what I'm talking about here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services