tillrohrmann commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r319197321
########## File path: flink-core/src/test/java/org/apache/flink/core/memory/ByteBufferUtilsTest.java ########## @@ -0,0 +1,101 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.flink.core.memory; + +import org.junit.Assert; +import org.junit.Test; + +import java.nio.ByteBuffer; + +import static org.hamcrest.Matchers.greaterThan; +import static org.hamcrest.Matchers.is; +import static org.hamcrest.Matchers.lessThan; + +/** + * Tests for {@link ByteBufferUtils}. + */ +public class ByteBufferUtilsTest { + + @Test + public void testBBWriteAndRead() { + + ByteBuffer bb = ByteBuffer.allocateDirect(4096); + doTest(bb, 0); + doTest(bb, 1); + doTest(bb, 2); + doTest(bb, 3); + doTest(bb, 4); + doTest(bb, 5); + doTest(bb, 6); + doTest(bb, 7); + + bb = ByteBuffer.allocate(4096); + doTest(bb, 0); + doTest(bb, 1); + doTest(bb, 2); + doTest(bb, 3); + doTest(bb, 4); + doTest(bb, 5); + doTest(bb, 6); + doTest(bb, 7); + } + + @Test + public void testCompareHeapBufferWithDirectBuffer() { + byte[] bytes = new byte[]{'a', 'b', 'c', 'd', 'e'}; + final int len = bytes.length; + ByteBuffer heapBuffer = ByteBuffer.wrap(bytes); + ByteBuffer directBuffer = ByteBuffer.allocateDirect(len); + directBuffer.put(bytes); + int res = ByteBufferUtils.compareTo(heapBuffer, 1, len - 1, directBuffer, 1, len - 1); + Assert.assertThat(res, is(0)); + res = ByteBufferUtils.compareTo(heapBuffer, 0, len - 1, directBuffer, 1, len - 1); + Assert.assertThat(res, lessThan(0)); + res = ByteBufferUtils.compareTo(heapBuffer, 1, len - 1, directBuffer, 0, len - 1); + Assert.assertThat(res, greaterThan(0)); + } + + private void doTest(ByteBuffer bb, int offset) { + int positionOri = bb.position(); + + ByteBufferUtils.putInt(bb, offset, 123); + Assert.assertEquals(bb.position(), positionOri); + Assert.assertEquals(123, ByteBufferUtils.toInt(bb, offset)); + Assert.assertEquals(bb.position(), positionOri); + + ByteBufferUtils.putLong(bb, offset + 4, 1234); + Assert.assertEquals(bb.position(), positionOri); + Assert.assertEquals(1234, ByteBufferUtils.toLong(bb, offset + 4)); + Assert.assertEquals(bb.position(), positionOri); + + Assert.assertEquals(123, ByteBufferUtils.toInt(bb, offset)); + Assert.assertEquals(bb.position(), positionOri); + + ByteBuffer bb2 = ByteBuffer.allocate(12); + int positionOri2 = bb2.position(); + ByteBufferUtils.copyFromBufferToBuffer(bb, offset, bb2, 0, 12); + + Assert.assertEquals(ByteBufferUtils.toInt(bb2, 0), 123); + Assert.assertEquals(ByteBufferUtils.toLong(bb2, 4), 1234); + Assert.assertEquals(bb.position(), positionOri); + Assert.assertEquals(bb2.position(), positionOri2); Review comment: Also here, we are interleave a lot of assertions with modifications which makes it hard to understand the test. Is there a way to make it easier understandable what's going on? This might not make a big difference now, but if the test should fail later on, it will be much easier what is actually going on. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
