twalthr commented on a change in pull request #9545: [FLINK-13355][docs] Add documentation for Temporal Table Join in blink planner URL: https://github.com/apache/flink/pull/9545#discussion_r319484601
########## File path: docs/dev/table/streaming/temporal_tables.md ########## @@ -78,9 +82,36 @@ The concept of *Temporal Tables* aims to simplify such queries, speed up their e In the above example `currency` would be a primary key for `RatesHistory` table and `rowtime` would be the timestamp attribute. -In Flink, a temporal table is represented by a *Temporal Table Function*. +In Flink, this is represented by a *Temporal Table Function*. + +On the other hand, we have the requirement to join a changing dimension table which is an external database table. Review comment: Use headings to separate both examples instead of putting them into one long text. We should avoid `we` in documentation, who is `we` in this context? Instead you could rephrase to: `On the other hand, some use cases require to join a changing dimension table which is an external database table.` `Let's assume that `LatestRates` is a table (e.g. stored in)` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
