tillrohrmann commented on a change in pull request #9568: [Flink-12164][tests]
Harden JobMasterTest#testJobFailureWhenTaskExecutorHeartbeatTimeout
URL: https://github.com/apache/flink/pull/9568#discussion_r319575971
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
##########
@@ -95,8 +112,8 @@ ResourceID getOwnResourceID() {
return heartbeatListener;
}
- Collection<HeartbeatMonitor<O>> getHeartbeatTargets() {
- return heartbeatTargets.values();
+ Map<ResourceID, HeartbeatMonitor<O>> getHeartbeatTargets() {
+ return heartbeatTargets;
Review comment:
Let's guard this structure by wrapping it into `Collections.unmodifiableMap`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
