zentol commented on a change in pull request #9560: [FLINK-13897][oss] Move NOTICE file into META-INF directory URL: https://github.com/apache/flink/pull/9560#discussion_r319720852
########## File path: NOTICE-binary ########## @@ -4732,11 +4851,6 @@ Copyright 2014-2019 The Apache Software Foundation flink-fs-hadoop-shaded Copyright 2014-2019 The Apache Software Foundation -This project includes software developed at -The Apache Software Foundation (http://www.apache.org/). - -This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) - Review comment: I didn't do any manual changes; I just built everything, ran the collect_licenses script and removed some unrelated changes. I'll double check whether an older jar sneaked in, and how the notice file in the oss jar looks like. AFAIK the shade-plugin isn't deduplicating entries, so this is indeed odd. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
