lirui-apache commented on a change in pull request #9580: [FLINK-13930][hive]
Support Hive version 3.1.x
URL: https://github.com/apache/flink/pull/9580#discussion_r319798412
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -109,4 +112,53 @@ void alterPartition(IMetaStoreClient client, String
databaseName, String tableNa
*/
SimpleGenericUDAFParameterInfo
createUDAFParameterInfo(ObjectInspector[] params, boolean isWindowing,
boolean distinct, boolean allColumns);
+
+ /**
+ * Get the class of Hive's MetaStoreUtils because its package name was
changed in Hive 3.1.0.
+ *
+ * @return MetaStoreUtils class
+ */
+ Class<?> getMetaStoreUtilsClass();
+
+ /**
+ * Get the class of Hive's HiveMetaStoreUtils as it was split from
MetaStoreUtils class in Hive 3.1.0.
+ *
+ * @return HiveMetaStoreUtils class
+ */
+ Class<?> getHiveMetaStoreUtilsClass();
+
+ /**
+ * Hive Date data type class was changed in Hive 3.1.0.
+ *
+ * @return Hive's Date class
+ */
+ Class<?> getDateDataTypeClass();
+
+ /**
+ * Hive Timestamp data type class was changed in Hive 3.1.0.
+ *
+ * @return Hive's Timestamp class
+ */
+ Class<?> getTimestampDataTypeClass();
+
+ /**
+ * The return type of HiveStatsUtils.getFileStatusRecurse was changed
from array to List in Hive 3.1.0.
+ *
+ * @param path the path of the directory
+ * @param level the level of recursion
+ * @param fs the file system of the directory
+ * @return an array of the entries
+ * @throws IOException in case of any io error
+ */
+ FileStatus[] getFileStatusRecurse(Path path, int level, FileSystem fs)
throws IOException;
+
+ /**
+ * The signature of HiveStatsUtils.makeSpecFromName() was changed in
Hive 3.1.0.
+ *
+ * @param partSpec partition specs
+ * @param currPath the current path
+ * @param notUsed newly added argument (which we don't care)
Review comment:
Why do we need this parameter here if it's never used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
