pnowojski commented on a change in pull request #9564:
[FLINK-12481][FLINK-12482][FLINK-12958] Streaming runtime: integrate mailbox
for timer triggers, checkpoints and AsyncWaitOperator
URL: https://github.com/apache/flink/pull/9564#discussion_r319896679
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -1139,17 +1138,9 @@ public void triggerCheckpointBarrier(
if (executionState == ExecutionState.RUNNING && invokable !=
null) {
- // build a local closure
- final SafetyNetCloseableRegistry
safetyNetCloseableRegistry =
-
FileSystemSafetyNet.getSafetyNetCloseableRegistryForThread();
-
Runnable runnable = new Runnable() {
@Override
public void run() {
- // set safety net from the task's
context for checkpointing thread
Review comment:
To me it looks like
`FileSystemSafetyNet.setSafetyNetCloseableRegistryForThread` should be called
by any thread that will be executing some/any part of the code that used to be
invoked in `invokable.triggerCheckpoint`. This is the entry point, where safety
net registry was being set, and then it was being used implicitly via static
variables in `SnapshotDirectory` via `FileSystem#getLocalFileSystem`.
> we are not calling any user code and file system operations in the
dispatcher thread anymore.
I guess yes, probably setting it here now doesn't make sense, but it
shouldn't be just removed from here, but moved used inside the mailbox action?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
