tillrohrmann commented on a change in pull request #8303: [FLINK-12343]
[flink-yarn] add file replication config for yarn configuration
URL: https://github.com/apache/flink/pull/8303#discussion_r319968797
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -746,6 +746,17 @@ public ApplicationReport startAppMaster(
// ship list that enables reuse of resources for task manager
containers
StringBuilder envShipFileList = new StringBuilder();
+ int fileReplication =
yarnConfiguration.getInt(DFSConfigKeys.DFS_REPLICATION_KEY,
DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+ if
(flinkConfiguration.contains(YarnConfigOptions.FILE_REPLICATION)) {
+ try {
+ final String replication =
flinkConfiguration.getString(YarnConfigOptions.FILE_REPLICATION);
Review comment:
Ah I see what the problem is. `ConfigOption<Integer>` must have a default
value. Maybe we can define a default value which is not respected by providing
an explicit default value `flinkConfiguration.getInteger(FILE_REPLICATION,
fileReplication)` where `fileReplication` comes from the `yarnConfiguration`.
Then we must document that we use this value as the default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
