wangyang0918 commented on a change in pull request #9587: [FLINK-13685][yarn]
Validate YARN deployment against YARN scheduler maximum vcore size
URL: https://github.com/apache/flink/pull/9587#discussion_r320145395
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -483,12 +483,14 @@ private void
validateClusterSpecification(ClusterSpecification clusterSpecificat
}
final int yarnMinAllocationMB =
yarnConfiguration.getInt(YarnConfiguration.RM_SCHEDULER_MINIMUM_ALLOCATION_MB,
0);
+ final int yarnSchedulerMaxVcores =
yarnConfiguration.getInt(YarnConfiguration.RM_SCHEDULER_MAXIMUM_ALLOCATION_VCORES,
0);
Review comment:
We do not need to get the scheduler max vcores from yarn configuration. Use
`maximumResourceCapability.getVirtualCores()` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
