tillrohrmann commented on a change in pull request #9555: [FLINK-13868][REST]
Job vertex add taskmanager id in rest api
URL: https://github.com/apache/flink/pull/9555#discussion_r320186252
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfoTest.java
##########
@@ -47,34 +48,37 @@ protected JobVertexDetailsInfo getTestResponseInstance()
throws Exception {
random.nextBoolean(),
random.nextLong(),
random.nextBoolean());
- List<JobVertexDetailsInfo.VertexTaskDetail>
vertexTaskDetailList = new ArrayList<>();
- vertexTaskDetailList.add(new
JobVertexDetailsInfo.VertexTaskDetail(
+ List<SubtaskExecutionAttemptDetailsInfo> vertexTaskDetailList =
new ArrayList<>();
+ vertexTaskDetailList.add(new SubtaskExecutionAttemptDetailsInfo(
0,
ExecutionState.CREATED,
random.nextInt(),
"local1",
System.currentTimeMillis(),
System.currentTimeMillis(),
1L,
- jobVertexMetrics));
- vertexTaskDetailList.add(new
JobVertexDetailsInfo.VertexTaskDetail(
+ jobVertexMetrics,
+ ""));
Review comment:
Maybe assign non empty resource id (e.g. `"resourceId1"`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
