AHeise commented on a change in pull request #9483: [FLINK-13767][task] Migrate
isFinished method from AvailabilityListener to AsyncDataInput
URL: https://github.com/apache/flink/pull/9483#discussion_r320743013
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamTwoInputProcessor.java
##########
@@ -174,30 +173,30 @@ public boolean isFinished() {
}
@Override
- public boolean processInput() throws Exception {
+ public InputStatus processInput() throws Exception {
// the preparations here are not placed in the constructor
because all work in it
// must be executed after all operators are opened.
prepareForProcessing();
int readingInputIndex = selectNextReadingInputIndex();
if (readingInputIndex == -1) {
- return false;
+ return InputStatus.NOTHING_AVAILABLE;
}
lastReadInputIndex = readingInputIndex;
- InputStatus status;
+ InputStatus status, anotherStatus;
Review comment:
`anotherStatus` is not really expressive. How about `otherInputStatus`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
