zhijiangW commented on a change in pull request #9483: [FLINK-13767][task]
Migrate isFinished method from AvailabilityListener to AsyncDataInput
URL: https://github.com/apache/flink/pull/9483#discussion_r321054294
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/AvailabilityListener.java
##########
@@ -55,7 +50,7 @@
* @return a future that is completed if there are more records
available. If there are more
* records available immediately, {@link #AVAILABLE} should be
returned. Previously returned
* not completed futures should become completed once there is more
input available or if
- * the input {@link #isFinished()}.
+ * the input is finished.
Review comment:
Not quite sure of it. `isFinished()` is more proper to be provided by input
interface to indicate whether this input ends or not. As for
`AvailabilityListener`, we just explain that which cases would cause future
complete. Or I did not get your key point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
