TisonKun commented on a change in pull request #9607: [FLINK-13946] Remove job
session related code from ExecutionEnvironment
URL: https://github.com/apache/flink/pull/9607#discussion_r321090559
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
##########
@@ -101,17 +101,6 @@ public ClusterClient(Configuration flinkConfig) {
this.timeout = AkkaUtils.getClientTimeout(flinkConfig);
}
- //
------------------------------------------------------------------------
- // Startup & Shutdown
- //
------------------------------------------------------------------------
-
- /**
- * User overridable hook to close the client, possibly closes internal
services.
- */
- public void shutdown() throws Exception {
Review comment:
As I have discussed with @tillrohrmann in FLINK-13750, maybe it is also
reasonable we have a empty impl for `close` in `ClusterClient` and let only
those who actually requires cleanups override it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
