TisonKun commented on a change in pull request #9620: [FLINK-13959] Consolidate
DetachedEnvironment and ContextEnvironment
URL: https://github.com/apache/flink/pull/9620#discussion_r321093602
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
##########
@@ -61,7 +61,10 @@ public JobSubmissionResult submitJob(JobGraph jobGraph,
ClassLoader classLoader)
if (isDetached()) {
try {
- return jobSubmissionResultFuture.get();
+ final JobSubmissionResult jobSubmissionResult =
jobSubmissionResultFuture.get();
+
+ this.lastJobExecutionResult = new
DetachedJobExecutionResult(jobSubmissionResult.getJobID());
Review comment:
Nice catch! I just notice that we not set `lastJobExecutionResult` in
MiniCluster case. I think it might be hopefully we eventually get rid of it(we
will unify all submission code path by `submitJob` instead of `run`s which the
only method require `lastJobExecutionResult`), but let's keep consistency now
which also helps convinced refactors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
