tillrohrmann commented on issue #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#issuecomment-528239153 Thanks for the general answers @carp84. 1. Ok, then I guess that `CopyOnWriteSkipListStateMap.stateSnapshot` is only being called under the checkpoint lock? If this is the case, then it should be ok. Maybe a clarifying comment could help here. 2. That's what I was suspecting. I don't wanna necessarily change it but do we know how much performance we gain by this? I think there would have been also other solutions to the problem. For example, one could have a reusable object which has a mutable `nodeAddress` field. Then one would not have to create a new object every time. Ideally one would hide this behind a factory method which can decide how to handle it. Also the access to the field could have been encapsulated by the object and if needed could have happened lazily. The benefit of this approach would be that it is easier to maintain and test because the API would tell you what such an object can do and we would have a dedicated type instead of longs you have to pass around.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
