zentol commented on a change in pull request #9555: [FLINK-13868][REST] Job
vertex add taskmanager id in rest api
URL: https://github.com/apache/flink/pull/9555#discussion_r321128309
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobVertexDetailsInfo.java
##########
@@ -122,6 +122,7 @@ public int hashCode() {
public static final String FIELD_NAME_END_TIME = "end-time";
public static final String FIELD_NAME_DURATION = "duration";
public static final String FIELD_NAME_METRICS = "metrics";
+ public static final String FIELD_NAME_RESOURCE_ID =
"resource-id";
Review comment:
`resource-id` is ambiguous; it's not clear what resource the ID belongs to.
`taskmanager-id` seems more appropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
