kl0u commented on a change in pull request #9620: [FLINK-13959] Consolidate 
DetachedEnvironment and ContextEnvironment
URL: https://github.com/apache/flink/pull/9620#discussion_r321186895
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
 ##########
 @@ -61,7 +61,10 @@ public JobSubmissionResult submitJob(JobGraph jobGraph, 
ClassLoader classLoader)
 
                if (isDetached()) {
                        try {
-                               return jobSubmissionResultFuture.get();
+                               final JobSubmissionResult jobSubmissionResult = 
jobSubmissionResultFuture.get();
+
+                               this.lastJobExecutionResult = new 
DetachedJobExecutionResult(jobSubmissionResult.getJobID());
 
 Review comment:
   Yes, I fixed that in this PR. Before it was not failing because in the 
`ClusterClient.run(...)` we had the second check in the `if 
(lastJobExecutionResult == null) ...` which was returning `false`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to