walterddr commented on issue #8468: [FLINK-12399][table] Adding PushDownTableSource interface to fix FilterableTableSource applyPredicate problem URL: https://github.com/apache/flink/pull/8468#issuecomment-528444343 Thanks for the suggestions @KurtYoung @JingsongLi . actually yeah, that's pretty much what I was intended to do in #8389. But I think the addition of (1) documentations and (2) sanity checks should be a good idea. My concern also lies with the point @godfreyhe had in the original PR: if we have other types of pushdown-able table sources. we will have a lengthy match/case clause in the TableScan rules to handle each of these separately (and like @JingsongLi mentioned, it is easy to missed one or two table source when modifying code) However to get this move forward, I will try to separate that concern into another JIRA to discuss how do we improve this in the future. For now I will restore the PR in the original approach. What do you guys think?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
