tillrohrmann commented on a change in pull request #9501: [FLINK-12697] [State Backends] Support on-disk state storage for spill-able heap backend URL: https://github.com/apache/flink/pull/9501#discussion_r321347548
########## File path: flink-state-backends/flink-statebackend-heap-spillable/src/main/java/org/apache/flink/runtime/state/heap/space/SpaceUtils.java ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.heap.space; + +import static org.apache.flink.runtime.state.heap.space.Constants.FOUR_BYTES_BITS; +import static org.apache.flink.runtime.state.heap.space.Constants.FOUR_BYTES_MARK; + +/** + * Utils. + */ +public class SpaceUtils { + + public static int getChunkIdByAddress(long offset) { + return (int) ((offset >>> FOUR_BYTES_BITS) & FOUR_BYTES_MARK); + } + + public static int getChunkOffsetByAddress(long offset) { + return (int) (offset & FOUR_BYTES_MARK); + } +} Review comment: What I don't like so much about this class is that it is somehow disconnected from `Chunk` or the `Allocator` where we generate the addresses. I think this is a drawback of the procedural approach that we don't group code and abstractions together. You need to have a lot of contextual knowledge to know that there is a `SpaceUtils` which offers you to transform a `long` into an `int` which represents the chunk id. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
