[ 
https://issues.apache.org/jira/browse/FLINK-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924104#comment-16924104
 ] 

TisonKun edited comment on FLINK-13990 at 9/6/19 10:09 AM:
-----------------------------------------------------------

In fact, {{JobMasterException}} referred above is 
{{o.a.f.runtime.jobmaster.exception.JobMasterException}}.

We have another in used {{JobMasterException}}, 
{{o.a.f.runtime.jobmaster.JobMasterException}}. However, it has only one used 
point. So a valid issue is to investigate whether we can handle that used point 
in different(maybe more proper) way and adjust our exceptions inheritance.

I would not include any investigation of the latter into this issue, though.


was (Author: tison):
In fact, {{JobMasterException}} referred above is 
{{o.a.f.runtime.jobmaster.exception.JobMasterException}}.

We have another in used {{JobMasterException}}, 
{{o.a.f.runtime.jobmaster.JobMasterException}}. However, it has only one used 
point. So a valid issue is to investigate whether we can handle that used point 
in different(maybe more proper) way and adjust our exceptions inheritance.

> Remove JobModificationException
> -------------------------------
>
>                 Key: FLINK-13990
>                 URL: https://issues.apache.org/jira/browse/FLINK-13990
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: TisonKun
>            Priority: Major
>             Fix For: 1.10.0
>
>
> As for its name {{JobModificationException}}, I'm not sure whether the 
> purpose underneath still valid. But none of our codepaths use this exception. 
>  I think it was mainly used in {{Dispatcher}} but we evolve exception 
> handling there. We can always add back once it is back to valid.
> Propose to remove it.
> cc [~till.rohrmann]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to