zentol commented on a change in pull request #9637: [FLINK-13884] Set default
delay for restart strategies to 1s
URL: https://github.com/apache/flink/pull/9637#discussion_r321671367
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/recovery/SimpleRecoveryFailureRateStrategyITBase.java
##########
@@ -43,7 +43,7 @@ private static Configuration getConfiguration() {
config.setString(RestartStrategyOptions.RESTART_STRATEGY,
"failure-rate");
config.setInteger(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_MAX_FAILURES_PER_INTERVAL,
1);
config.setString(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL,
"1 second");
-
config.setString(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_DELAY,
"100 ms");
+
config.setString(RestartStrategyOptions.RESTART_STRATEGY_FAILURE_RATE_DELAY, "0
s");
Review comment:
why are we reducing the delay here? This doesn't seem strictly necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
